laravel-enso / enso

Laravel Vue SPA, Bulma themed. For demo login use `admin@laravel-enso.com` & `password` -
https://www.laravel-enso.com
MIT License
1.08k stars 278 forks source link

Component emitted event "edit" but it is neither declared in the emits option nor as an "onEdit" prop. #414

Closed mauthi closed 2 years ago

mauthi commented 2 years ago

This is a bug.

Prerequisites

Description

After click on edit button e.g. in userGroups table I get the following warning after update to Vue 3:

image

I tried to add emits: ['edit'], to @enso-ui/user-groups/src/bulma/pages/userGroups/Index.vue but it did not remove the warning.

Steps to Reproduce

  1. Log in
  2. Open developer console
  3. Go to Administration -> User Groups
  4. Click on edit on one row

Expected behavior

No warning

Actual behavior

Warning

aocneanu commented 2 years ago

The warning is caused by vue3, which recommends documenting all events in the component that emits them.

Unfortunately, dynamic event names is not supported yet, but don't worry, you won't have any problems with it.

Meanwhile you can follow https://github.com/vuejs/rfcs/issues/204

mauthi commented 2 years ago

Thx - in that case I will close this.