laravel-enso / enso

Laravel Vue SPA, Bulma themed. For demo login use `admin@laravel-enso.com` & `password` -
https://www.laravel-enso.com
MIT License
1.08k stars 277 forks source link

Datetime filters may be misleading on the "time" part. #435

Open robbykrlos opened 1 year ago

robbykrlos commented 1 year ago

This is a minor bug.

Prerequisites

Description

Even though the testing of this issue is not working on 5.0.0 (see https://github.com/laravel-enso/enso/issues/434), the behavior we've seen on 4.9.1 is misleading when it comes to "datetime" filters. Here is why:

If you have a datetime filter Created At, it will ask you only for date. You select 21.02.2023. Your data is having random datetimes like 21.02.2023 10:35:23 ... (with time)

The condition applied in BE is 21.02.2023 00:00:00 == 21.02.2023 10:35:23 which is false. So basically using a datetime filter with value (not interval) is pointless since it will only target entries with time 00:00:00.

Shouldn't time be part of the filter, or when selecting a day, it should cover the whole 24h interval (00:00:00 -> 23:59:59)?

robbykrlos commented 1 year ago

Any updates?