laravel-frontend-presets / bulma

Bulma Frontend Preset For Laravel Framework 5.5 and Up
https://laravel-frontend-presets.github.io/bulma
171 stars 25 forks source link

Problem with some components #26

Closed merlinnusr closed 5 years ago

merlinnusr commented 5 years ago

The styles doesn't apply for inputs, I didn't modify any of login.blade.php image

I notice also that I have an old version of Bulma but I don't know it is normal. image

I followed this tutorial https://github.com/laravel-frontend-presets/bulma#usage, it doens't work

robertgarrigos commented 5 years ago

I'm having the same problem and found a work around to fix it.

This composer package is installing the node bulma module 0.7.5, as it's setting a dev dependency in package.json as:

"bulma": "^0.7.4",

which allows node to install the latest package before 0.8, and the problem is that 0.7.5, which is the one installing right now, is triggering the bug. You just need to change your package.json file as:

"bulma": "0.7.4",

So it will install exactly 0.7.4 version, which is working fine.

robertgarrigos commented 5 years ago

I don't know why, but this line:

https://github.com/laravel-frontend-presets/bulma/blob/88f6c5ff3cc21f0b3c1aed17d639ff60bd48aca7/src/bulma-stubs/bulma.sass#L14

which fixes the problem with bulma, is not present in the composer package installed by the composer require command.

thus, instead of using bulma 0.7.4, better add this line https://github.com/laravel-frontend-presets/bulma/blob/88f6c5ff3cc21f0b3c1aed17d639ff60bd48aca7/src/bulma-stubs/bulma.sass#L14

to your resources/sass/bulma.sass file

robertgarrigos commented 5 years ago

This is strange. I don't know how composer works, but something is wrong with it. I required bulma preset as usual and this is the composer.lock file generated:

 "name": "laravel-frontend-presets/bulma",
            "version": "v2.0.4",
            "source": {
                "type": "git",
                "url": "https://github.com/laravel-frontend-presets/bulma.git",
                "reference": "a857f1569f3153c0bee7e9ef130f0aae832b7b6f"

the version pulled off seems to be correct, but in fact the reference number is of a couple of commits before, so that's why it doesn't contain the updates to bulma 0.7.5.

robertgarrigos commented 5 years ago

I see, it's not composer problem. The reference number is ok. It is the 2.0.4 release, which does not include the changes applied with the commit 88f6c5ff3cc21f0b3c1aed17d639ff60bd48aca7. @Laraveldeep would need to create a new release with that commit.

robertgarrigos commented 5 years ago

thanks @m1guelpf

robertgarrigos commented 5 years ago

I don't know how long it takes packagist.org to update their packages. If you need to update the bulma package you can also do:

composer require laravel-frontend-presets/bulma:dev-master

do a npm update also and artisan preset bulma-authto get latest bulma

deeshrestha commented 5 years ago

@robertgarrigos Sorry was travelling. Didn't get time to check this. I have updated the Packagist. Thanks @m1guelpf