search

laravel-frontend-presets / tall

A TALL (Tailwind CSS, Alpine.js, Laravel and Livewire) Preset for Laravel
MIT License
2.42k stars 203 forks source link

Laravel 9.x Compatibility #100

Closed laravel-shift closed 2 years ago

laravel-shift commented 2 years ago

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

If you do find an issue, please report it by commenting on this PR to help improve future automation.

laravel-shift commented 2 years ago

:warning: Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 9. However, you should review these changes to ensure the desired combination of versions are built for your package.

laravel-shift commented 2 years ago

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/tall.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "laravel-frontend-presets/tall": "dev-l9-compatibility",
    }
}

Finally, run: composer update

dominikgeimer commented 2 years ago

Tried the Shift Repo. Looks good.

danharrin commented 2 years ago

It's bumped the minimum version though... which is weird. would have thought it added it as another.

jasonmccreary commented 2 years ago

@danharrin, it's based on the previous support level, which was the "latest version".

danharrin commented 2 years ago

Tried the Shift Repo. Looks good.

The tests are failing for Laravel 9, so this is going to need some more investigation. I am more than happy to handle this, or if it is helpful to @jasonmccreary then he can use the failed tests to extend the L9 Shift :)

ryangjchandler commented 2 years ago

@danharrin Looks like the configuration of the tests is wrong, will take a look later.

danharrin commented 2 years ago

It's not just the missing sender address, it's also the fact that the password rule has been renamed to current_password.

ryangjchandler commented 2 years ago

@danharrin We should probably just use 9.x then and look at moving to TW 3 too.

danharrin commented 2 years ago

Sure. I think the package needs a rewrite anyway. Add some rate limiting and everything.

danharrin commented 2 years ago

New design