search

laravel-frontend-presets / tall

A TALL (Tailwind CSS, Alpine.js, Laravel and Livewire) Preset for Laravel
MIT License
2.42k stars 203 forks source link

Update welcome.blade.php #127

Closed morpheus7CS closed 1 year ago

morpheus7CS commented 1 year ago

Hey to all,

currently, when the TALL preset is applied, and the user registers and logs into the application, the Home link on the welcome.blade.php view points to /home, which results in a 404.

I have updated the link to point to route('home') instead of the current url('/home') to fix this.

Kind regards, g

danharrin commented 1 year ago

Thanks

Supernova3339 commented 1 year ago

Sorry to put this to concern, but wouldn't RouteServiceProvider::home make more sense?

morpheus7CS commented 1 year ago

@Supernova3339 hey,

it probably would, if the functionality would have been the same as in Breeze, but since this preset doesn't ship with a dashboard.blade.php view that is present there, I just wanted to avoid 404s on a starter project as it might confuse the beginners who are merely starting out.

I think most people will override the welcome.blade.php view entirely shortly after installation, so this change made sense to me.

Kind regards, g