laravel-frontend-presets / tall

A TALL (Tailwind CSS, Alpine.js, Laravel and Livewire) Preset for Laravel
MIT License
2.42k stars 203 forks source link

change path and routes #132

Closed bhargavraviya closed 10 months ago

bhargavraviya commented 1 year ago
danharrin commented 1 year ago

Hey, please fix the tests

bhargavraviya commented 1 year ago

Hi @danharrin , there is no issue in your test case, but in your test case system, it shows an error. https://github.com/laravel-frontend-presets/tall/actions/runs/5707042038/job/15464764322 please guide me on how to solve this.

danharrin commented 1 year ago

I think you need to replace the strings like auth.login with the full class name Login::class for LW3 @bhargavraviya

bhargavraviya commented 1 year ago

auth @danharrin thank you for the replay I have changed the test case please check again if it is correct or not

bhargavraviya commented 11 months ago

@danharrin Any test case error is pending please guide me

johnpbloch commented 11 months ago

@bhargavraviya I think the workflow file (.github/workflows/tests.yml) needs to be updated to install v3 of livewire under the "Install Dependencies" step.

bhargavraviya commented 11 months ago

@bhargavraviya I think the workflow file (.github/workflows/tests.yml) needs to be updated to install v3 of livewire under the "Install Dependencies" step.

I have already livewire v3

@johnpbloch @danharrin

johnpbloch commented 11 months ago

Yes, but the test runner in GitHub actions doesn't.

Tests will pass for this PR after that.

bhargavraviya commented 11 months ago

I have changes Done

@johnpbloch please check and merged it

johnpbloch commented 11 months ago

@danharrin will have to take care of that.