Closed marcorieser closed 4 years ago
Happy to merge this one in. Thanks @marcorieser ❤️
@marcorieser Do you fancy adding this to the test suite for the reset component? I'd do it myself but I can't push to your fork since the changes were on master.
@ryangjchandler What do you mean by: ?
I'd do it myself but I can't push to your fork since the changes were on master.
How are you able to push to one of my repos even if my changes were on a separated branch? Maybe I missed some of the pull request logic here? ☺️
@marcorieser GitHub will let a maintainer of a repository push to your fork / PR's branch when you open the PR, unless you tell GitHub otherwise.
Thanks for adding that assertion in though!
GitHub will let a maintainer of a repository push to your fork / PR's branch when you open the PR, unless you tell GitHub otherwise.
oh, didn't know that. very nice 👍
In the password reset form it would be nice to prefill the email field with the query parameter.