Upgrade UIkit version and remove jquery dependency

laravel-frontend-presets / uikit3

Laravel 5.5+ Front-end preset for UIKit 3.

https://laravel-frontend-presets.github.io/uikit3

44 stars 11 forks source link

Upgrade UIkit version and remove jquery dependency #10

Closed cesaramirez closed 6 years ago

cesaramirez commented 6 years ago

Upgrade to Uikit Version 3.0.0-Beta.34 and remove jquery dependency, that was removed from version 3.0.0-Beta.31 https://github.com/uikit/uikit/releases/tag/v3.0.0-beta.31

OwenMelbz commented 6 years ago

Hey @cesaramirez thanks for giving this a look.

I'm a little hesitant to merge it right now as by including the laravel bootstrap.js file in the package, your putting the responsibility of maintaining it on us - which is not something we'd ideally want to do.

I'm happy removing jquery and updating the version number, however its secret change number 3 which I'm not keen on.

cesaramirez commented 6 years ago

Hello, checking the other presets that are in the organization I have seen that it is the solution they have used, overwriting the bootstrap.js file. Why do not you want to make the same solution in this case?