search

laravel-frontend-presets / uikit3

Laravel 5.5+ Front-end preset for UIKit 3.
https://laravel-frontend-presets.github.io/uikit3
44 stars 11 forks source link

Include theme in your template #9

Closed alesvaupotic closed 4 years ago

alesvaupotic commented 7 years ago

Much easier start I guess and the suggested way from the docs.

Without themes, styling is different from what a new user might expect as they browse the official documentation. Form input for example has no border ... the difference was confusing to me at first.

Maybe we can suggest including original files and comment it out? Or just reverse it and comment out the themed files?

I agree on including each component separately as it is much easier to remove the non-used before going to production. Consider abstracting it in a separate file. Importing that from app.scss would clean it up a bit and make a safer environment while editing the variables.

OwenMelbz commented 7 years ago

Hi @alesvaupotic thanks for the suggestion.

We'll give it a think over - as we'll never please everybody, if we do it 1 way, then people who use it the other way will want it back.

I'm away for the next 2 weeks so will try give it a look and understand the consequences of changing this when I'm back.

alesvaupotic commented 7 years ago

Sure, Owen, take all the time you need. I am just a fan of including non-default options commented out so I can quickly adapt without the manual. Laravel Front End Presets are still new in the community so there are no guidelines present, I guess.

OwenMelbz commented 6 years ago

Hi @alesvaupotic sorry for such a long delay - has been very busy few months!

Could you just explain the difference between your PR again?

I see it removes the default mixins and variables for "theme" mixins

Whats the difference between these for the end user?