laravel-idea / plugin

Laravel Idea plugin for PhpStorm
https://laravel-idea.com/
177 stars 7 forks source link

[Bug]: Qodana support - issues detected in pipeline are autofixed in IDE #1077

Open azgooon opened 1 month ago

azgooon commented 1 month ago

Bug description

Following the recent release of the plugin with Qodana support I noticed that the number of issues detected when Qodana runs in IDE differs from the number of the problems detected in the pipeline. For example I can see "undefined variables" detected in the blades when Qodana report generated in the pipelines but then when I load this report in the phpStorm and navigate to the issue, within the second or two its getting marked as "fixed".

https://github.com/user-attachments/assets/d636fb4a-4d0d-4a75-9fc2-492e1765eeb7

Plugin version

8.3.3.242

Operating system

Windows

Steps to reproduce

  1. run qodana in the pipeline with laravel idea plugin
  2. export reports to the qodana cloud
  3. import report to the phpStorm
  4. go to the detected issue (this does not happen with all issues) but i.e undefined variables in the blade
  5. watch issue getting marked as fixed without doing anything.

Relevant log output

No response

adelf commented 1 month ago

Hello.

run qodana in the pipeline with laravel idea plugin

How did you run it? Qodana doesn't support paid plugins yet. We are going to release a special release of Laravel Idea for Qodana.

azgooon commented 1 month ago

I was under the impression that it supports it as per the change log:

Version 8.3:
Create Facade and Create Service code generations
Laravel 11 Service providers registration
Laravel 11 new container attributes support
JetBrains Qodana support
Translation keys fetching optimization

So I just set it up according to the qodana docs.

However this behaviour would make sense if the plugin is not runing in the pipeline.

adelf commented 1 month ago

I'm sorry for this misinformation. We will release a plugin for Qodana soon.

"JetBrains Qodana support" means that we made some changes inside the plugin to make this possible. I'll write here when the new plugin will be released.

azgooon commented 1 month ago

That's great, thank you.