laravel-idea / plugin

Laravel Idea plugin for PhpStorm
https://laravel-idea.com/
160 stars 7 forks source link

[Bug]: Incorrect class imported when select Slack as the notification channel #987

Open abishekrsrikaanth opened 1 month ago

abishekrsrikaanth commented 1 month ago

Bug description

When creating a Notification and selecting Slack as the channel, the notification class gets created correctly, but the toSlack method is created with Illuminate\Notifications\Message\SlackMessage as reference instead of Illuminate\Notifications\Slack\SlackMessage

Plugin version

8.1.4.241

Operating system

MacOS

Steps to reproduce

  1. Install Slack Notifications on a new Laravel App
  2. Create a notification and select slack as the channel on the Create Notification Window.

Relevant log output

No response

spoyntersmith commented 3 weeks ago

@adelf Would you consider this a bug too / related?

image

Since nexmo is no longer, I believe the type should be vonage and the boilerplate changed

    public function toVonage($notifiable): VonageMessage
    {
        return (new VonageMessage)
            ->content('...');
    }