search

laravel-json-api / eloquent

Serialize Eloquent models to JSON API resources
MIT License
12 stars 15 forks source link

Change reserved word ReadOnly to ReadOnlyAble (for php >= 8.1) #25

Closed ValikoDorodnov closed 2 years ago

lindyhopchris commented 2 years ago

Hi! thanks for taking the time to create a PR... I'm guessing you worked out this has already been fixed on the 2.x branch. I'm just waiting for Laravel 9 to get tagged before tagging a major release of Laravel JSON:API.

ValikoDorodnov commented 2 years ago

Hello, yeah, saw this work at 2.x branch and close my PR, thank you! One more question, can i use this library without checking auth? In tutorial i must create make:policy, and request to application redirect me to login route (but i don't need one for now)

Sorry my English)

вт, 25 янв. 2022 г. в 11:47, Christopher Gammie @.***>:

Hi! thanks for taking the time to create a PR... I'm guessing you worked out this has already been fixed on the 2.x branch. I'm just waiting for Laravel 9 to get tagged before tagging a major release of Laravel JSON:API.

— Reply to this email directly, view it on GitHub https://github.com/laravel-json-api/eloquent/pull/25#issuecomment-1020940873, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMMLBIM4WN266MH6SSP7ZW3UXZPSRANCNFSM5MXNTKDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you modified the open/close state.Message ID: @.***>

lindyhopchris commented 2 years ago

@ValikoDorodnov you can disable authorization on your Server class, as per these docs: https://laraveljsonapi.io/docs/1.0/requests/authorization.html#disabling-authorization

ValikoDorodnov commented 2 years ago

Thank you very match! Sorry for disturbing you, have a nice day!

вт, 25 янв. 2022 г. в 14:26, Christopher Gammie @.***>:

@ValikoDorodnov https://github.com/ValikoDorodnov you can disable authorization on your Server class, as per these docs:

https://laraveljsonapi.io/docs/1.0/requests/authorization.html#disabling-authorization

— Reply to this email directly, view it on GitHub https://github.com/laravel-json-api/eloquent/pull/25#issuecomment-1021090039, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMMLBINHWGGYRBATWFXDJD3UX2CFBANCNFSM5MXNTKDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>