search

laravel-notification-channels / aws-sns

AWS SNS notification channel for Laravel
https://laravel-notification-channels.com/aws-sns
MIT License
50 stars 9 forks source link

Dependencies issues #17

Closed undjike closed 3 years ago

undjike commented 3 years ago

To be able to install the package on Laravel 8.40, it's needed to:

Installation failed unless you do that. I had to execute

composer require laravel-notification-channel/aws-sns -with-all-dependencies

for it to work (by performing these 2 actions automatically)

claudsonm commented 3 years ago

Will take a look at this when I have the time.

In the mean time, PRs fixing the issue are also welcome.

claudsonm commented 3 years ago

After a long while, I've addressed the issue. Huge thanks for pointing it out.

The problem resides in aws-sdk-php. They support guzzlehttp/guzzle 7.x, but not the guzzlehttp/ps7 2.x. The problem is affecting a lot of other packages, including things on the Laravel ecosystem such as Laravel Vapor.

Maintainers of the AWS SDK are already digging into it. As we can follow here: https://github.com/aws/aws-sdk-php/issues/2264

For now, I will let composer solve the conflict of dependencies, and just update the docs to instruct people to install this package using the --update-with-dependencies flag.