search

laravel-notification-channels / facebook

📨 Facebook Notifications Channel for Laravel
https://laravel-notification-channels.com/facebook/
MIT License
151 stars 32 forks source link

Installation Guide #5

Closed christophrumpel closed 8 years ago

christophrumpel commented 8 years ago

Hey,

just tried it and it is working. Great work! Only one two things I that could be better:

1.) Installation description If you're not into Facebook it is really hard to understand what is happening and what are we / you going to achieve. Where does the message pop up? Which chat window between who?

I would also add some information about the "page-scoped User ID" what that is and where to get that. I got a chatbot already setup where I copied this ID, but I would not know where else I could get ip.

2.) Optional to() method. What is happening if I don't use that method? I didn't get that.

Cheers

irazasyed commented 8 years ago

Hey @christophrumpel,

Thanks for testing and opening this issue with your feedback, I appreciate it.

Here are my answers:

  1. Yes, I have this on my Todo List to improve the instructions, Ref: #2. I needed to push the code ASAP as to make sure other collaborators get access to it like @themsaid had mentioned. So those instructions are quite incomplete, and I know that already. A lot of things to improve in that section. If you're joining as a collaborator for this package, then feel free to contribute to that part ofc :)
  2. Optional to() is when you want to override the routeNotificationForFacebook() method in your notifiable model or you don't add at all. This is present in my another package too. Good to have in various cases. I had provided more info in Routing a message section, perhaps it wasn't so clear?

Cheers!

christophrumpel commented 8 years ago

Oh of course @irazasyed , sry =) Let me know when you are finished with the documentation, then I can test it too if you like.

Nr. 2 ist now clear too me, I didn't read it carefully. Now I did =) Also let me know if you need help. thx!

irazasyed commented 8 years ago

No probs!

I could definitely use some help with installation guide right now. I'm still working on improving the code right now, So documentation is open for any contributions. If you wanna jump in and do it, That would be good :)