laravel-notification-channels / fcm

Firebase Cloud Messaging (FCM) notifications channel for Laravel
https://laravel-notification-channels.com/
MIT License
495 stars 127 forks source link

fix: spatie/enum v3 compatibility fixes #56

Closed ryzr closed 4 years ago

ryzr commented 4 years ago

As per https://github.com/spatie/enum/pull/56#issuecomment-631313764, there were some breaking changes to spatie/enum v3, which was merged in https://github.com/laravel-notification-channels/fcm/pull/50

~I've replaced usages of $enum->getValue() with $enum->label, and pinned the dependency to ^3.0 (removing ^2.3), as it is not backwards compatible between the two versions.~

To maintain compatibility with projects dependant on spatie/enum ^2.3, usages of $enum->getValue() have been replaced with the null coalescing $enum->label ?? $enum->getValue()

Please consider merging this, or reverting https://github.com/laravel-notification-channels/fcm/pull/50, as currently, priority and visibility can not be set for Android FCM notifications.