Open WouterFlorijn opened 3 years ago
Currently, use of this package is inconsistent. In most cases (for example in the via method), the channel needs to be MessagebirdChannel::class. However, when routing an anonymous notification, the channel needs to be 'messagebird':
via
MessagebirdChannel::class
'messagebird'
Notification::route('messagebird', $phoneNumber)->notify(...);
I think Notification::resolved could be used in the MessagebirdServiceProvider to accomplish this. See for example the Nexmo implementation.
Notification::resolved
MessagebirdServiceProvider
@petericebear What is needed to resolve this issue? Looking if I can help somehow, but I see a PR has been made already.
Currently, use of this package is inconsistent. In most cases (for example in the
via
method), the channel needs to beMessagebirdChannel::class
. However, when routing an anonymous notification, the channel needs to be'messagebird'
:I think
Notification::resolved
could be used in theMessagebirdServiceProvider
to accomplish this. See for example the Nexmo implementation.