search

laravel-notification-channels / microsoft-teams

Microsoft Teams Notifications Channel for Laravel
https://laravel-notification-channels.com
MIT License
137 stars 15 forks source link

Too few arguments to function ::routeNotificationFor(), 1 passed, 2 expected #11

Closed tdondich closed 2 years ago

tdondich commented 3 years ago

On line 38 of MicrosoftTeamsChannel, you're calling 

            $to = $notifiable->routeNotificationFor('microsoftTeams');

However, routeNotificationFor should have a 2nd argument which is the $notification object. This SHOULD be changed to

            $to = $notifiable->routeNotificationFor('microsoftTeams', $notification);
Tob0t commented 3 years ago

thanks for the input, I will fix it asap

wit3 commented 2 years ago

Any news?

Tob0t commented 2 years ago

@Wit3 sorry for inactivity, will merge the PR asap