search

laravel-notification-channels / onesignal

OneSignal notifications channel for Laravel
MIT License
283 stars 119 forks source link

Laravel 8 Support #116

Closed atymic closed 4 years ago

atymic commented 4 years ago

Laravel 8 has been released today and we need to update this repo to support it. See https://laravel.com/docs/8.x/upgrade & https://github.com/laravel-notification-channels/channels/issues/107

ExpDev07 commented 4 years ago

I have oepend a PR here which should fix it: https://github.com/berkayk/laravel-onesignal/pull/135.

pedro-santiago commented 4 years ago

@ExpDev07 is this repo active? I've checked your PR (looking good, by the way), but they aren't quite very active, right?

ExpDev07 commented 4 years ago

@pedro-santiago yeah, doesn’t look like they’re very active. But this project depends on that one.

atymic commented 4 years ago

If there's no movement in the next few days, you can always switch to a fork of that package See the composer docs

ExpDev07 commented 4 years ago

@atymic right, but I believe the owner of that repo is the same as this one XD

atymic commented 4 years ago

I don't have permissions on the other repo (I do on this one, as it's part of the notification channels)

LKaemmerling commented 4 years ago

I don't have permissions on the other repo (I do on this one, as it's part of the notification channels)

The upgrade is already partially within master :) We just need to migrate the tests from travis (as it isn't working anymore) to Github Actions, then we have the tests again which should have shown that the berkayk/laravel-onesignal#135 is not ready yet

atymic commented 4 years ago

Should be good now 👍