Laravel 9.x Compatibility

laravel-notification-channels / onesignal

OneSignal notifications channel for Laravel

MIT License

283 stars 119 forks source link

Laravel 9.x Compatibility #137

Closed laravel-shift closed 2 years ago

laravel-shift commented 2 years ago

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

Checkout the l9-compatibility branch
Review all comments for additional changes
Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

laravel-shift commented 2 years ago

:warning: The latest version of Laravel has a dependency for phpunit/phpunit of ^9.3. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

laravel-shift commented 2 years ago

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/onesignal.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "laravel-notification-channels/onesignal": "dev-l9-compatibility",
    }
}

Finally, run: composer update

lkmadushan commented 2 years ago

@mpociot any update about the release date of Laravel 9 support?

faytekin commented 2 years ago

If you send notifications only with OneSignal Player ID, the macellan/onesignal package has Laravel 9 compatibility.

AshPowell commented 2 years ago

@LKaemmerling @mpociot any eta on the merge?

Thanks

cbaconnier commented 2 years ago

I believe using this PR will currently fail since it depends on this PR (see below) that is also not merged ~~https://github.com/berkayk/laravel-onesignal/pull/159~~

innocenzi commented 2 years ago

I believe using this PR will currently fail since it depends on this PR that is also not merged berkayk/laravel-onesignal#159

This one should be merged instead, https://github.com/berkayk/laravel-onesignal/pull/162, since the one you linked didn't include Guzzle updates - but yes you're right, this PR should be merged after support for L9 is added to berkayk/laravel-onesignal