search

laravel-notification-channels / onesignal

OneSignal notifications channel for Laravel
MIT License
283 stars 119 forks source link

Remove return type #54

Closed timacdonald closed 6 years ago

timacdonald commented 6 years ago

I thought this whole project had return types, but turns out I added the only one. I removed it for consistency throughout the codebase.

LKaemmerling commented 6 years ago

In my opinion we should see that all Methods has return types. @Lloople what do you think?

Lloople commented 6 years ago

Minimum required version is greather than PHP 7.0, I think it's good for the project to have typehinted returns, we can add them as we're fixing bugs or adding code 🙂

timacdonald commented 6 years ago

To easy, I’ll leave that one there then :)