Closed timacdonald closed 6 years ago
Also, sorry about the PR spam - I've just been working a lot with this today and came across a few things - thanks for maintaining the package!
Nice catch! Thank you!
OT: Why would someone doesn't set a subject for a notification?
My current client wanted to ditch the subject and just have what content of the chat post was - so had to work out how to remove it :)
The only required parameter of the
OneSignalMessage
should be the body / contents. However, due to how the subject was previously added in thetoArray()
method, OneSignal would throw an error due to an empty subject.Let's see some code.
Here you can see I am not setting the subject. Now let's look at the
toArray()
method:OneSignal throws an error if you provide an empty value for the subject as above:
This PR implements a new method called
subjectToArray()
which will only return the language / value key pair if there is a subject set - otherwise an empty array is returned. This fixes the above OneSignal error.