search

laravel-notification-channels / onesignal

OneSignal notifications channel for Laravel
MIT License
283 stars 119 forks source link

Min Php Version #57

Closed ecomunicarte closed 6 years ago

ecomunicarte commented 6 years ago

The title of the package is "...for Laravel 5.3+", but the min PHP version is 7.0 since the package's version 1.1.0. I have seen that in changelog after hours looking for why it does not work.

Laravel 5.3, and 5.4 don't require PHP 7, so I think you could indicate that requirement in the readme.

LKaemmerling commented 6 years ago

As of Version 1.1.0 the min PHP Version is 7.0.0, the Changelog says these: https://github.com/laravel-notification-channels/onesignal/blob/master/CHANGELOG.md

If you want to use it in PHP Version < 7.0.0 the latest working version is 1.0.2.

ecomunicarte commented 6 years ago

Ok, so I think it must be indicated in readme since the requirements are different from laravel ones.