laravel-notification-channels / onesignal

OneSignal notifications channel for Laravel
MIT License
283 stars 119 forks source link

ability of user to send notification , filtering for multiple tags #73

Closed rylxes closed 6 years ago

rylxes commented 6 years ago

the current notification sending by tags filtering

public function routeNotificationForOneSignal() { return ['tags' => ['key' => 'device_uuid', 'relation' => '=', 'value' => '123e4567-e89b-12d3-a456-426655440000']]; }

Ability to filter by more than one tag i.e public function routeNotificationForOneSignal() { return ['tags' => [ ['key' => 'device_uuid', 'relation' => '=', 'value' => '123e4567-e89b-12d3-a456-426655440000'], ['key' => 'role', 'relation' => '=', 'value' => 'admin'] ] ]; }

rylxes commented 6 years ago

71

LKaemmerling commented 6 years ago

Could you please rebase this on the refactor-to-traits branch?

rylxes commented 6 years ago

I have done that, ... the current branch is up to date

LKaemmerling commented 6 years ago

For me this looks okay @Lloople what do you think?