search

laravel-notification-channels / onesignal

OneSignal notifications channel for Laravel
MIT License
283 stars 119 forks source link

Target external user IDs #86

Closed JeffreyHyer closed 5 years ago

JeffreyHyer commented 5 years ago

A small change that allows you to send notifications to users by specifying an external user ID.

See the OneSignal docs under 'include_external_user_ids' for all the details.

LKaemmerling commented 5 years ago

Can you add a test for this please?

JeffreyHyer commented 5 years ago

@LKaemmerling I've added the test, thanks for the feedback.

LKaemmerling commented 5 years ago

LGTM @Lloople what do you think?

Lloople commented 5 years ago

Looks good. Is there a way to test the content of the $payload? It’s the only thing I’m missing, being sure the external_ids are there.

LKaemmerling commented 5 years ago

@Lloople the payload is already tested in https://github.com/laravel-notification-channels/onesignal/pull/86/files#diff-6e36f1a1becd7049f27f18c6212bced0R255 or am i wrong?

Lloople commented 5 years ago

You’re right! I didn’t saw it from the phone 😅