search

laravel-notification-channels / onesignal

OneSignal notifications channel for Laravel
MIT License
283 stars 119 forks source link

Allow Laravel 6 #98

Closed AshPowell closed 5 years ago

Lloople commented 5 years ago

Thank you for your PR!

PHPUnit and Testbench should be updated too

@LKaemmerling Could you please take a look into this and make sure everything is right? 🙏

AshPowell commented 5 years ago

Thank you for your PR!

PHPUnit and Testbench should be updated too

@LKaemmerling Could you please take a look into this and make sure everything is right? 🙏

Yep completely didn't think!, Sorry for closing too just saw the notification and assumed a separate, complete pull request was created.

AshPowell commented 5 years ago

@LKaemmerling just in case you missed it 😀

LKaemmerling commented 5 years ago

Actually i see the tests are failing. Could you please remove php 7.0 ? I guess we can release this then as the final 2.0

LKaemmerling commented 5 years ago

@AshPowell @Lloople could you look over this again? I have fixed the phpunit tests.

AshPowell commented 5 years ago

With the checks being removed for older php versions, should v2 also require php ^7.2?

Lloople commented 5 years ago

Looks good to me 👍 Only remaining thing is the matter @AshPowell said about backward compatibility, because I'm not so sure about what we're about to do 😅

LKaemmerling commented 5 years ago

Let's wait on travis, then i guess we can release this :)