search

laravel-notification-channels / pusher-push-notifications

Pusher Beams notifications channel for Laravel
http://laravel-notification-channels.com
MIT License
271 stars 67 forks source link

Include exception into the NotificationFailed event #66

Closed Stalinko closed 2 years ago

Stalinko commented 2 years ago

I was trying to gracefully process pusher errors in my project and figured out that currently it's impossible to get the actual error message. Because the NotificationFailed event object doesn't include any details of the error occurred.

In this PR I'm fixing that.

I don't know if I must write any additional tests because the existing tests seems to cover this case already.

Stalinko commented 2 years ago

styleci fails like always. Let me know if I must do something with that.

Stalinko commented 2 years ago

Any updates of this PR? @atymic ? Also this PR has been waiting for long: https://github.com/laravel-notification-channels/pusher-push-notifications/pull/65

Both these features turned out super handy for me. So I have to keep using my fork for now and sync it with the main branch periodically.

atymic commented 2 years ago

Closed in #73