laravel-notification-channels / twilio

Twilio notifications channel for Laravel
https://laravel-notification-channels.com
227 stars 36 forks source link

Do not assume that the sid sent to client is the account sid #135

Open edgrosvenor opened 2 years ago

edgrosvenor commented 2 years ago

Twilio allows for the creation of api keys and tokens that can (arguably should) be used in lieu of the account sid and its token. Using the account sid and its token puts credentials in the wild that have the power to create new api keys and perform account-level operations that are not required or often appropriate for a system that just sends messages. This PR simply adds another configuration key sid that defaults to account_sid if it's not set. So now the user can configure the package to use an api key sid and its token, but if not, the package will continue to function exactly as it did before.