Closed lnpbk closed 7 years ago
Great! I'm just waiting for @casperboone confirmation to merge his pull request.
@leon13, I'm still waiting for @casperboone to commit more changes to his PR ;)
No problem
Sorry for the delay @leon13. I have been busy the past two week. I have now merged the @casperboone pull request. Can you refactor your changes over the new master branch? Thanks!
I'm currently working on this, and hope to have it done within the next couple of days
If anyone has the ability to test the calling ability with this code, that'd be great. I only have SMS capable numbers at the moment.
This is ready for review @gregoriohc
Is there any traction on this? Would love to see the Twilio 5+ sdk implemented while we transition over from inhouse notifications to the Laravel 5.3 package but can't install 4 & 5 simultaneously.
@mickeyschwab Unfortunately I haven't heard anything. Feel free to try my fork
Sorry guys. I have been very busy the last few months and I haven't tested this yet. I will try to do it this week. @lnpbk, this PR has breaking changes with the current version, isn't it? Maybe the best thing we can do is to merge it and release a new 2.0 version?
No probs @gregoriohc. I don't believe there are any breaking changes, but maybe it'd be wise to tag a new version, as my PR bumps the Twilio Sdk version requirement up to version 5.
@lnpbk @gregoriohc do you need help here? I would like to have this released as the current version doesn't work anymore (I'm getting ""Could not resolve host: "" as exception message) and as far as I can trace it's because SDK 4.x so I would like to upgrade.
Let me know if I can help you (coding) so we can get this official release soon.
@TonnyORG Thanks for the offer, and any review of the PR is greatly appreciated!
Having the same issue as @TonnyORG
It seems they may have discontinued the version 4 api, finally.
Using @lnpbk version and seems to work fine for sms, I am also only on a trial account so can't test the calling functionality.
Sorry for the delay. This has been tested, merged and released as 2.0.0 version.
I have added 2 new features:
Messaging Service
The ability to use a Twilio Messaging Service. Just add
sms_service_sid
to your Twilio services config, like so:Alphanumeric Senders
To implement alphanumeric senders, add your sender name to your Twilio services config, like so:
Alphanumeric senders are available on a county-by-country basis (https://support.twilio.com/hc/en-us/articles/223133767-International-support-for-Alphanumeric-Sender-ID), so you need to implement the following method on your
$notifiable
class:Use this method to determine whether the Model can receive Alphanumeric senders or not
Footnote
I noticed @casperboone's pull request, which looks great, and once pulled in, I'd be happy to contribute these changes to the new format.