Add/improve tests, improve testability and refactor

[casperboone]

As this is currently the most downloaded package, I thought the tests needed some attention to prove the working to its users.

Note: This PR proposes something a little different than #14. Pick what you like most ;).

I have done the following:

• Used a parallel test hierarchy for the message tests.
• Created tests for the channel
• Created tests for the provider
• Changed the config helper method in the provider to $this->app['config']
• Changed TwilioAbstractMessage to TwilioMessage
• Created integration tests
• Refactored a lot from TwilioChannel to Twilio. This made the tests, but also the code in general a lot cleaner and more readable.
• Created tests for Twilio

[casperboone]

Since this PR is changing quite a lot, please try it out in an actual Laravel application before releasing it. I'm not a Twilio user myself, so I'm not able to actually use it. Please let me know if anything goes wrong, so I can fix it ;).

I prefer this PR over #14, since this one made the tests, but also the code in general a lot cleaner and more readable. However, it does introduce some changes you might not like. So, pick the one you like most ;).

[gregoriohc]

Hi @casperboone,

I prefer this PR to the other one. There is only one problem. When I try to make real test, it gives me the following error:

Illuminate\Contracts\Container\BindingResolutionException with message 'Unresolvable dependency resolving [Parameter #1 [ $from ]] in class NotificationChannels\Twilio\Twilio'

The problem is in the bindings. When you call $this->app->make(TwilioService::class) in the Service Provider the container doesn't know that the calling class is \NotificationChannels\Twilio\Twilio, so it doesn't resolve it.

I have found two possible solutions on the Service Provider boot method. The first one would look like this:

$this->app->when(TwilioChannel::class)
    ->needs(Twilio::class)
    ->give(function () {
        $config = $this->app['config']['services.twilio'];

        return new Twilio(
            $this->app->make(TwilioService::class, [
                $config['account_sid'],
                $config['account_sid'],
            ]),
            $config['from']
        );
    });

And the other option would look like this:

$this->app->when(Twilio::class)
    ->needs(TwilioService::class)
    ->give(function () {
        $config = $this->app['config']['services.twilio'];

        return new TwilioService(
            $config['account_sid'],
            $config['auth_token']
        );
    });

$this->app->when(Twilio::class)
    ->needs('$from')
    ->give($this->app['config']['services.twilio.from']);

Which one do you prefer? Can you fix it and pull the commit? Thanks!!

[casperboone]

Fixed it, thanks! :)