search

laravel-notification-channels / webhook

Webhook notifications channel for Laravel
https://laravel-notification-channels.com
MIT License
170 stars 61 forks source link

Allow customisation of Guzzle options #23

Closed nmokkenstorm closed 5 years ago

nmokkenstorm commented 5 years ago

This PR adds some functionality and extendability that has been heavily requested. The feature I was missing to be able to use this package for a project I'm working on was being able to customise the options passed to Guzzle ( mostly SSL as requested here ).

The main change I made was depending on a Guzzle\ClientInterface instead of Client, and then making it possible to customise the binding resolution using a config file.

As a side effect of some code cleanup I did it's now also possible to pass an array of URLs as requested here. If necessary I can split this PR in 2 parts, but looking at the outstanding PRs and issues I figured that doing it in one go might be more efficient.

nmokkenstorm commented 5 years ago

The CI builds seems to be partially failing due to PHP versions. Laravel currently requires 7.1 at the minimum, so I kept it at that, not sure how to solve this for the PR