Closed rcrosbourne closed 9 months ago
Sorry, this commit is way too large with too many commits and changes for me to consider. If you want a new feature added, I recommend separating your PR into multiple. First making the feature, then additional for refactors.
Thanks for your feedback. This feature involved addingulid
support for models, migrations and factories. So there would be a lot of files changes. I can take a phased approach by adding support for migrations only and slowly add the rest.
Please resolve any open conversation and I'll give this a final review.
Looks like there's still a bit of lint. Run composer update
locally and then vendor/bin/pint
. It's probably a new rule in Pint that's not being applied.
Looks like there's still a bit of lint. Run
composer update
locally and thenvendor/bin/pint
. It's probably a new rule in Pint that's not being applied.
Yes that worked. Thanks.
List of changes:
Model
andModelGenerator
classesModel
class.customer_id
andtran_id
added.ulidMorphs
added to the test fixtures in all-column-types for drafts, models, and factories.MigrationGeneratorTest.php
file.ulid
type toModelLexer.php
.Blueprint.php
to matchulid
anduuid
.