laravel / browser-kit-testing

Provides backwards compatibility for BrowserKit testing in the latest Laravel release.
MIT License
509 stars 75 forks source link

replace deprecated PHPUnit assetArraySubset method with an extension … #106

Closed traubisoda closed 5 years ago

traubisoda commented 5 years ago

As of version 9 of PHPUnit, the method assertArraySubset() will be deprecated, and version 8 throws a warning if this assertion is used.

This PR is replacing the deprecated method (used in seeJsonSubset()) with this PHPUnit extension, as suggested by the PHPUnit maintainer in this issue: https://github.com/sebastianbergmann/phpunit/issues/3494#issuecomment-480283612

driesvints commented 5 years ago

This seems to break the Travis build. Looks like that package doesn't supports PHPUnit 7 which this release of browser kit still supports.