search

laravel / browser-kit-testing

Provides backwards compatibility for BrowserKit testing in the latest Laravel release.
MIT License
509 stars 75 forks source link

Allow PHPUnit 9 #121

Closed crynobone closed 4 years ago

crynobone commented 4 years ago

Also update minimum PHPUnit version to follow Laravel 7 deps.

Signed-off-by: Mior Muhammad Zaki crynobone@gmail.com

driesvints commented 4 years ago

Can we also allow this on 5.x for people on Laravel 6.x?

crynobone commented 4 years ago

Can we also allow this on 5.x for people on Laravel 6.x?

I'm a bit worried that someone using Laravel 5.x will end up getting PHPUnit 9 and get error with deprecated methods.

driesvints commented 4 years ago

@crynobone but won't they get the same than on this version? There's no other changes here than the bumped dependency.

crynobone commented 4 years ago

Laravel 5.x doesn't have https://github.com/laravel/framework/blob/6.x/src/Illuminate/Foundation/Testing/Assert.php

driesvints commented 4 years ago

@crynobone you're correct. Thanks!