search

laravel / browser-kit-testing

Provides backwards compatibility for BrowserKit testing in the latest Laravel release.
MIT License
508 stars 75 forks source link

[6.x] GitHub actions #124

Closed driesvints closed 4 years ago

driesvints commented 4 years ago

For browser-kit-testing I'm sending this to master since we're about to release 6.x

GrahamCampbell commented 4 years ago
image
driesvints commented 4 years ago

@GrahamCampbell fixed

GrahamCampbell commented 4 years ago

Hmm, adding all these extensions makes a major difference to the build time. Setting them up takes longer than running composer and the test suite?

GrahamCampbell commented 4 years ago

Also shivammathur/setup-php@v1 is outdated. There is a v2 now?

driesvints commented 4 years ago

Hmm, adding all these extensions makes a major difference to the build time. Setting them up takes longer than running composer and the test suite?

Feel free to send in a follow up pr if you want.

GrahamCampbell commented 4 years ago

Feel free to send in a follow up pr if you want.

Other than the laravel/framework repo, we can probably drop almost all the extensions.

GrahamCampbell commented 4 years ago

https://github.com/laravel/browser-kit-testing/pull/125 seems much faster on the "setup php" step.

GrahamCampbell commented 4 years ago

2x speed up on the whole run.