search

laravel / browser-kit-testing

Provides backwards compatibility for BrowserKit testing in the latest Laravel release.
MIT License
509 stars 75 forks source link

[5.x] Copied #30101 #137

Closed bytestream closed 4 years ago

bytestream commented 4 years ago

Copied laravel/framework#30101 here

driesvints commented 4 years ago

@bytestream it's always best that you also add an explanation instead of linking to an issue/pr. See the PR template.

bytestream commented 4 years ago

I think the linked PR provides a more than adequate explanation of why the functionality is beneficial. This PR simply copies it's work. There's not much more that can be said.

The use of traits in Illuminate\Foundation\Testing and this package make it difficult to reuse the functionality added by that PR. I'd rather not have to pull in both traits and write a long list of conflict resolutions for every conflicting method.

jshah4517 commented 4 years ago

@driesvints Is it possible to have a new 5.x release including this?

driesvints commented 4 years ago

@jshah4517 I'll try to look into this next week.