search

laravel / browser-kit-testing

Provides backwards compatibility for BrowserKit testing in the latest Laravel release.
MIT License
509 stars 75 forks source link

MakesHttpRequest wrong return-value in phpdoc block #149

Closed indeyets closed 3 years ago

indeyets commented 3 years ago

Description:

MakesHttpRequests::call() is annotated to return \Illuminate\Http\Response, but it actually returns Laravel\BrowserKitTesting\TestResponse.

It leads to warnings from static analysis tools such as PhpStAn

Steps To Reproduce:

  1. check signature of TestResponse::fromBaseResponse
  2. compare it to signature of MakesHttpRequests::call()
driesvints commented 3 years ago

Feel free to PR something