search

laravel / browser-kit-testing

Provides backwards compatibility for BrowserKit testing in the latest Laravel release.
MIT License
509 stars 75 forks source link

[6.x] Use TestResponse as return value in PHPDoc #150

Closed indeyets closed 3 years ago

indeyets commented 3 years ago

Response-object originates from TestResponse::fromBaseResponse() call which returns "self".

In this case it means that \Laravel\BrowserKitTesting\TestResponse class would always be used.

This should solve some of the issues reported by PhpStAn.

related to #149

p.s. is it a policy to close issues before fix is provided? seems to discourage discussion. at least that's how it worked for me :-(

driesvints commented 3 years ago

p.s. is it a policy to close issues before fix is provided? seems to discourage discussion. at least that's how it worked for me :-(

@indeyets nothing was broken. This repo is open source so you're always free to send in a PR if you want to fix/change something.

indeyets commented 3 years ago

@driesvints ok. I guess my definition of brokenness is much broader I consider issues to be a kind of dynamic documentation of project. And I know that PRs out of the blue are not welcome in a lot of places so I prefer to start discussion in issues before changing code. Maintainers tend to have their own plans and opinions :) thank you!