Fix unit testing - Separe MakesHttpRequests to InteractsWithPages

laravel / browser-kit-testing

Provides backwards compatibility for BrowserKit testing in the latest Laravel release.

MIT License

508 stars 75 forks source link

Fix unit testing - Separe MakesHttpRequests to InteractsWithPages #88

Closed ericktucto closed 5 years ago

ericktucto commented 5 years ago

Separating unit tests for the InteractsWithPages and MakesHttpRequests class

On MakesHttpRequestsTest, the methods:

prepareUrlForRequest
seeStatusCode
assertResponseOk
assertResponseStatus

belong to MakesHttpRequests class and the rest of the methods belong to InteractsWithPages

Changes to be committed:

copied: tests/Unit/MakesHttpRequestsTest.php -> tests/Unit/InteractsWithPagesTest.php
modified: tests/Unit/MakesHttpRequestsTest.php

driesvints commented 5 years ago

Actually, I see that there are some of my commits from master in this PR. It's best that you re-try by branching off from 5.0 and send this in again. You can cherry pick your commit.

ericktucto commented 5 years ago

Sorry, I made this PR on 5.0 branch. I should have done this PR on master branch. It was an error