Separe MakesHttpRequests to InteractsWithPages

laravel / browser-kit-testing

Provides backwards compatibility for BrowserKit testing in the latest Laravel release.

MIT License

509 stars 75 forks source link

Closed ericktucto closed 5 years ago

ericktucto commented 5 years ago

Separating unit tests for the InteractsWithPages and MakesHttpRequests class

On MakesHttpRequestsTest, the methods:

belong to MakesHttpRequests class and the rest of the methods belong to InteractsWithPages

Changes to be committed:

copied: tests/Unit/MakesHttpRequestsTest.php -> tests/Unit/InteractsWithPagesTest.php
modified: tests/Unit/MakesHttpRequestsTest.php

driesvints commented 5 years ago

No no, you can still send it in to 5.0. That's perfectly fine. Just branch off from 5.0 branch.

There's nothing breaking as tests are part of anything the user of a package will touch. Any changes will be merged into master.