[5.0] Separe MakesHttpRequests to InteractsWithPages

laravel / browser-kit-testing

Provides backwards compatibility for BrowserKit testing in the latest Laravel release.

MIT License

509 stars 75 forks source link

[5.0] Separe MakesHttpRequests to InteractsWithPages #90

Closed ericktucto closed 5 years ago

ericktucto commented 5 years ago

Separating unit tests for the InteractsWithPages and MakesHttpRequests class

On MakesHttpRequestsTest, the methods:

prepareUrlForRequest
seeStatusCode
assertResponseOk
assertResponseStatus

belong to MakesHttpRequests class and the rest of the methods belong to InteractsWithPages

Changes to be committed: copied: tests/Unit/MakesHttpRequestsTest.php -> tests/Unit/InteractsWithPagesTest.php modified: tests/Unit/MakesHttpRequestsTest.php

driesvints commented 5 years ago

@ErickTucto I had to release a bugfix just now so you'll have to rebase with 5.0

ericktucto commented 5 years ago

Okay. Sorry, I was busy over the weekend so I did not answer