[5.0] Separe unit testing

laravel / browser-kit-testing

Provides backwards compatibility for BrowserKit testing in the latest Laravel release.

MIT License

508 stars 75 forks source link

[5.0] Separe unit testing #91

Closed ericktucto closed 5 years ago

ericktucto commented 5 years ago

Separating unit tests for the InteractsWithPages and MakesHttpRequests class

On MakesHttpRequestsTest, the methods:

prepareUrlForRequest
seeStatusCode
assertResponseOk
assertResponseStatus

belong to MakesHttpRequests class and the rest of the methods belong to InteractsWithPages

Changes to be committed: copied: tests/Unit/MakesHttpRequestsTest.php -> tests/Unit/InteractsWithPagesTest.php modified: tests/Unit/MakesHttpRequestsTest.php

driesvints commented 5 years ago

You've removed the assertPageLoaded_throw_exception_with_response_exception test which I added as a bugfix by doing this. Please try to branch of from 5.0 entirely from start as I suggested before or you risk to remove functionality by working on outdated branches.

ericktucto commented 5 years ago

@driesvints This unit test assertPageLoaded_throw_exception_with_response_exception must belong to InteractsWithPagesTest class, because the exception thrown by the assertPageLoaded method belongs to the InteractsWithPages class.

I will move assertPageLoaded_throw_exception_with_response_exception to InteractsWithPagesTest class