laravel / browser-kit-testing

Provides backwards compatibility for BrowserKit testing in the latest Laravel release.
MIT License
508 stars 75 forks source link

Add shouldReport to withoutExceptionHandling instance #95

Closed okdewit closed 5 years ago

okdewit commented 5 years ago

shouldReport() was added to the ExceptionHandler interface. When it is not present in this trait, it throws an error when calling withoutExceptionHandling().

See this PR on Laravel Framework: https://github.com/laravel/framework/pull/26193

driesvints commented 5 years ago

Can you send this to the 5.0 branch instead? Thanks

okdewit commented 5 years ago

@driesvints I just saw that @ErickTucto made the same change to the 5.0 branch. I think all that is needed is a new tagged release :)

driesvints commented 5 years ago

@okdewit will probably happen tomorrow 👍