search

laravel / cashier-mollie

MIT License
375 stars 63 forks source link

[ERROR] InvalideMandateException -> subscription renewed #295

Closed blankflo closed 3 years ago

blankflo commented 3 years ago

Hi , I think i found an error, i'am currently using mollie as recurring solution . One of my client has deleted its mandate before the trial expires, and when the payment was processed an order with a mollie temporary id was created but without any status. The worst thing is the subscription has benn renewed for 2 months instead of stopping.

Error links ->https://sentry.io/share/issue/9f28f928f30440c19c1a9832a08289cd/ PS: if you need any help with the alpha , it will be pleasure to helps

Thank you for your time .

F.L

sandervanhooft commented 3 years ago

Hi @blankflo ,

Thanks for the ❤️ ! For the alpha testing of v2, please register here.

And thanks for reporting.

I'm seeing in your logs that the Laravel\Cashier\Exceptions\InvalidMandateException gets thrown (by this line), which is a good start.

This exception is not handled yet (haven't had this case before); catching it and triggering Order::handlePaymentFailed() will fix it. We'll patch this today.

blankflo commented 3 years ago

Thanks for the fast answer . I'am impatient to discover v2!

I will update mollie and test if its working now . I'll keep you informed.

F.L

sandervanhooft commented 3 years ago

Thanks!

Just released the patch.

This should prevent this issue in the future. However, you may need to call $order->handlePaymentFailedDueToInvalidMandate() manually on the order that went wrong before. According to your logs this order has ID 109.

blankflo commented 3 years ago

I'll do it right now .

Thanks a lot for your works !