search

laravel / cashier-stripe

Laravel Cashier provides an expressive, fluent interface to Stripe's subscription billing services.
https://laravel.com/docs/billing
MIT License
2.37k stars 670 forks source link

[15.x] Clear the generic trial upon subscription creation #1628

Closed driesvints closed 8 months ago

driesvints commented 8 months ago

These code changes will make sure a billable's generic trial is cleared when they start their subscription. As soon as a customer starts their subscription there's no need for the trial to continue since they have started paying. We also already do this in Spark Stripe.

AntonioDiPassio-AppSys commented 6 months ago

Why does the generic trial need to be cleared? Would it not be better to check if the generic trial has expired, and if not set the end date to now()? This still ensures there is no ongoing trial when a subscription is started, and at the same time you don't lose the information about when the trial ended. Because I would still like to know from when to when my clients were on trial before they started their first subscription.

driesvints commented 6 months ago

When a subscription starts, there's no need for a generic trial anymore because they've effectively started paying for the subscription. Previously, the customer still had the generic trial applied, making it appear as if they were still trialing, while in reality they already started the subscription.

The column in the database is really to note if a customer is currently trialing generically. After the subscription started it doesn't serves any purpose anymore. If you need this date for activity purposes we suggest you keep the info in an activity log somewhere.

AntonioDiPassio-AppSys commented 6 months ago

Setting the end date of the trial instead of clearing it would achieve the same result: Customer isn't on trial anymore. On top of that, it would be more accurate as the customer did end his trial the moment he started a subscription. Clearing the end date would make it appear as if the customer never had a trial in the first place.

driesvints commented 6 months ago

Right now we're not making any changes here. I'm sorry if this disrupted you.