fix(checkout): Unset 'return_url' for embedded UI without redirection

laravel / cashier-stripe

Laravel Cashier provides an expressive, fluent interface to Stripe's subscription billing services.

https://laravel.com/docs/billing

MIT License

2.38k stars 676 forks source link

fix(checkout): Unset 'return_url' for embedded UI without redirection #1630

Closed lowbits closed 9 months ago

lowbits commented 9 months ago

This commit resolves an issue with the handling of 'return_url' in the checkout process. When the UI mode is 'embedded' and 'redirect_on_completion' is set to 'never', 'return_url' is now consistently unset. This change prevents errors related to passing an empty 'return_url' and ensures compatibility with scenarios where no redirection is intended upon completion.

github-actions[bot] commented 9 months ago

Thanks for submitting a PR!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the relevant GitHub documentation. Additionally, GitHub doesn't allow maintainer permissions from organization accounts. Please resubmit this PR from a personal GitHub account with maintainer permissions enabled.