search

laravel / cashier-stripe

Laravel Cashier provides an expressive, fluent interface to Stripe's subscription billing services.
https://laravel.com/docs/billing
MIT License
2.37k stars 671 forks source link

Fix failing event meter tests #1707

Closed Bark-fa closed 4 weeks ago

Bark-fa commented 4 weeks ago

This should fix the issue in the ManagesUserBilling trait, tests passed locally

driesvints commented 4 weeks ago

Thanks!

driesvints commented 4 weeks ago

@Bark-fa tests still fail it seems: https://github.com/laravel/cashier-stripe/actions/runs/10452831229/job/28942077001

Bark-fa commented 4 weeks ago

I see it's failing on Laravel 10, is there any way I can test this locally? That's a very odd thing

driesvints commented 4 weeks ago

You can use composer require "illuminate/contracts=^10" --no-update to install Laravel v10 components to run the test suite.

Bark-fa commented 4 weeks ago

I just did, and the tests pass, is there any difference between what I would have by executing the composer command you gave me and the environment in which the tests are running? and what about the environment where the PR tests are getting evaluated on push?

driesvints commented 4 weeks ago

Did you hook up your stripe testing env? See https://github.com/laravel/cashier-stripe/blob/15.x/.github/CONTRIBUTING.md

Bark-fa commented 4 weeks ago

Yes I made sure of it, also ran it before I added the key just to make sure it throws a different kind of error

driesvints commented 4 weeks ago

Then I don't know what's different besides the PHP versions. In any case we'll need to get this fixed or I'll have to revert all before tomorrow when we do releases.

Bark-fa commented 4 weeks ago

Shot in the dark, but I'll try to call sleep(1) after reporting usage, maybe this has something to do with it, is there a way to keep the next PR open and still run the action?

driesvints commented 4 weeks ago

Yeah just put it in draft and you can play around with it 👍