search

laravel / cashier-stripe

Laravel Cashier provides an expressive, fluent interface to Stripe's subscription billing services.
https://laravel.com/docs/billing
MIT License
2.37k stars 671 forks source link

Add AED currency #842

Closed Messhias closed 4 years ago

Messhias commented 4 years ago

We need to add AED currency to the cashier.

driesvints commented 4 years ago

These currencies depend on stripe support. Out of the box, Cashier supports all currencies that Stripe supports.

Messhias commented 4 years ago

This is very easy to add.

Can I add the currency and open the PR?

There's a lot legacy system using the library (laracom for exemple).

On Sun, Dec 29, 2019, 01:35 Dries Vints notifications@github.com wrote:

These currencies depend on stripe support. Out of the box, Cashier supports all currencies that Stripe supports.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/laravel/cashier/issues/842?email_source=notifications&email_token=AAI3QQ63VLLVHDOUKLNQEA3Q27BANA5CNFSM4KAMLWK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHYSSMY#issuecomment-569452851, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI3QQ5UGRMXTJ7XC6FGKC3Q27BANANCNFSM4KAMLWKQ .

driesvints commented 4 years ago

Stripe already supports AED: https://stripe.com/docs/currencies

And Cashier makes use of the moneyphp/money library which also supports AED: https://github.com/moneyphp/money/blob/master/resources/currency.php#L1101

What exactly isn't working for you?

Messhias commented 4 years ago

The laracom uses this library and change it to stripe or whatever it'll be a lot headache and my approach is just add other condition in the switch case condition.

On Mon, Dec 30, 2019, 01:32 Dries Vints notifications@github.com wrote:

Stripe already supports AED: https://stripe.com/docs/currencies

And Cashier makes use of the moneyphp/money library which also supports AED: https://github.com/moneyphp/money/blob/master/resources/currency.php#L1101

What exactly isn't working for you?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/laravel/cashier/issues/842?email_source=notifications&email_token=AAI3QQ5KZP4KAZJWYX7LOZTQ3EJPHA5CNFSM4KAMLWK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZIZGY#issuecomment-569543835, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI3QQYUNEVGG6DJD4I6NO3Q3EJPHANCNFSM4KAMLWKQ .

driesvints commented 4 years ago

We can't offer support for third party libraries. You'll have to ask the maintainers of Laracom to offer support for Cashier.

Messhias commented 4 years ago

Hello,

But this is not for only support third parties, this is for also another kind currency could be added on library.

Anyway, I already changed the core by myself and I keep my version.

Thank you,

Best Regards,

Fabio William Conceição

Remote: https://remote.com/fabiowilliam Tel/Whastapp: +971 52 503 3008 Skype: fabioo.william.conceicao LinkedIn: https://www.linkedin.com/in/fabio-william-concei%C3%A7%C3%A3o-379b9823/ Github: https://github.com/Messhias/ Upwork: https://www.upwork.com/o/profiles/users/_~0126d10487b9843f68/

On 30 Dec 2019, at 2:09 PM, Dries Vints notifications@github.com wrote:

We can't offer support for third party libraries. You'll have to ask the maintainers of Laracom to offer support for Cashier.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/laravel/cashier/issues/842?email_source=notifications&email_token=AAI3QQ6GXBIXGH55E24O23DQ3HCFBA5CNFSM4KAMLWK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHZ6UOA#issuecomment-569633336, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI3QQ4YSHIJLX72ABB5XSLQ3HCFBANCNFSM4KAMLWKQ.