search

laravel / cashier-stripe

Laravel Cashier provides an expressive, fluent interface to Stripe's subscription billing services.
https://laravel.com/docs/billing
MIT License
2.37k stars 671 forks source link

noProrate() not working while updating quantity of a multiplan item #923

Closed rambo666 closed 4 years ago

rambo666 commented 4 years ago

Description:

While I update a plan quantity belonging to a multiplan subscriptin. Putting noProrate does not work. After I went to the stripe I can still see remaining time of quantity being invoiced.

I used the following code to update quantity for my plan $user->subscription('default')->noProrate()->updateQuantity($qty,$subscriptionPlan)

Even though I used noProrate() the invoice on stripe was still prorating and showing remaining time of quantity on the invoice.

Steps To Reproduce:

Apply no prorate while updating quantity on stripe while there are multiplans on a subscription.

driesvints commented 4 years ago

Thanks, I also see the problem here. You've been very helpful so far, thanks!

driesvints commented 4 years ago

Sent in a PR for this: https://github.com/laravel/cashier/pull/924