Closed ziadoz closed 7 months ago
Thanks for submitting a PR!
Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.
Pull requests that are abandoned in draft may be closed due to inactivity.
Can we make the PR not change the names of screenshots for tests that use no data set?
@taylorotwell I've pushed a test to prove the filenames are unchanged if there's no data set.
If there's a failure in a Dusk test case that uses PHPUnit data providers, then only a screenshot of the last data set that failed will be available in the
screenshots
directory. This is because without the data set in the filename, each new screenshot overwrites the previous one.This PR adds the data set, where applicable, to the filenames of screenshots and console output:
With no data provider:
With unnamed data set (
0
,1
):With named data set (
foo
,bar
):I've retained the existing 140 character filename limit by trimming it off the left hand side of the filename, so namespaces are truncated.