search

laravel / dusk

Laravel Dusk provides simple end-to-end testing and browser automation.
https://laravel.com/docs/dusk
MIT License
1.87k stars 320 forks source link

Support Dusk Selectors in `screenshotElement` #1094

Closed rabrowne85 closed 5 months ago

rabrowne85 commented 5 months ago

in the previous PR #1093 the use of Dusk selectors were not supported. This formats the selector as per other methods thereby supporting the use of Dusk selectors.

u01jmg3 commented 5 months ago

You need to fix the tests test_element_screenshot and test_element_screenshot_in_subdirectory due to your change.

rabrowne85 commented 5 months ago

Thanks @u01jmg3.

Tests have been revised to suit the corrections to the method. I also renamed the tests to follow the same naming of the method.